Issue 20287: In windows 7 there is a new Reg call that we need to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20287: In windows 7 there is a new Reg call that we need to... (Closed)

Created:
11 years, 10 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

In windows 7 there is a new Reg call that we need to hook. NtOpenKeyEx. I don't know what the last parameter is. I suspect it's a reserved flag for "options". (As in RegOpenKeyEx). I do not handle the case where this unknown flag is non-zero. The current unit tests covers this code. bug:7611 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9762

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 1

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -8 lines)			Patch
M	sandbox/src/nt_internals.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	sandbox/src/registry_dispatcher.cc	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	sandbox/src/registry_interception.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	sandbox/src/registry_interception.cc	View	1 2 3 4 5 6	2 chunks	+29 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/20287/diff/21/1038 File sandbox/src/registry_interception.cc (right): http://codereview.chromium.org/20287/diff/21/1038#newcode164 Line 164: // zero, we don't attemp to proxy the ...

11 years, 10 months ago (2009-02-12 00:14:20 UTC) #2

rvargas (doing something else)

11 years, 10 months ago (2009-02-12 01:05:01 UTC) #3

LGTM (Please add the bug number to the CL description)

Expand Messages | Collapse Messages