Issue 20281: Scrubbing HTMLPlugInElement V8 custom bindings, WebKit side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20281: Scrubbing HTMLPlugInElement V8 custom bindings, WebKit side. (Closed)

Created:
11 years, 10 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
macdome, eseidel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Scrubbing HTMLPlugInElement V8 custom bindings, WebKit side. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9778

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -0 lines)			Patch
	A	third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

macdome_gmail.com

11 years, 10 months ago (2009-02-12 00:08:50 UTC) #3

Otherwise looks good.  LGTM.

http://codereview.chromium.org/20281/diff/1/2
File third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp
(right):

http://codereview.chromium.org/20281/diff/1/2#newcode49
Line 49: ScriptInstance scriptInstance = imp->getInstance();
I would write this early-return style.  if (!scriptInstance)  return empty
handle;

http://codereview.chromium.org/20281/diff/1/2#newcode64
Line 64: v8::Local<v8::Object> instance =
v8::Local<v8::Object>::New(scriptInstance->instance());
same deal.  Early return style would be clearer IMO.

http://codereview.chromium.org/20281/diff/1/2#newcode82
Line 82: if (scriptInstance) {
ditto.

Expand Messages | Collapse Messages