Issue 20279: Add a unit test for ERR_UNEXPECTED_SERVER_AUTH....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20279: Add a unit test for ERR_UNEXPECTED_SERVER_AUTH.... (Closed)

Created:
11 years, 10 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a unit test for ERR_UNEXPECTED_SERVER_AUTH. Remove the obsolete change to URLRequestHttpJob::IsRedirectResponse, which was accidentally checked in. R=eroman BUG=7338 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9816

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -9 lines)			Patch
M	net/tools/testserver/testserver.py	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	1 2	2 chunks	+28 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years, 10 months ago (2009-02-12 01:16:30 UTC) #2

LGTM

http://codereview.chromium.org/20279/diff/1/4
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/20279/diff/1/4#newcode116
Line 116: // issue a CONNECT request with the magic host name
"www.server-auth.com" to
wording-nit: can probably remove the trailing "to it."

Expand Messages | Collapse Messages