Issue 20266: janitorial: clean up unnecessary includes in src/chrome/renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20266: janitorial: clean up unnecessary includes in src/chrome/renderer. (Closed)

Created:
11 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

janitorial: clean up unnecessary includes in src/chrome/renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9594

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -25 lines)			Patch
M	chrome/renderer/about_handler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_plugin_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/render_process.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/render_thread.h	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_widget.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/user_script_slave.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/user_script_slave.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/webmediaplayer_delegate_impl.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

This is great! Well done for doing this. LGTM. (I'd run it by a try ...

11 years, 10 months ago (2009-02-11 19:42:49 UTC) #2

Lei Zhang

11 years, 10 months ago (2009-02-11 19:45:11 UTC) #3

On 2009/02/11 19:42:49, agl wrote:
> This is great! Well done for doing this. LGTM.
> 
> (I'd run it by a try bot before committing, just to be sure)

I ran it on the trybots last night. Should be fine, but I'll keep an eye out for
problems in the next couple hours.

Expand Messages | Collapse Messages