Fetch SDCH dictionary as soon as current URL fetch completes...

Fetch SDCH dictionary as soon as current URL fetch completes

Rather than just waiting for 15 seconds, this patch fetches the
"suggested dicitionary" as soon as the current download completes.
This avoids stealing bandwidth from the original download, but 
works as quickly as possible to get the dictionary, so that the
user can receive compression results asap.

r=wtc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9597

[wtc, 2009-02-11 19:38:30]

LGTM.

http://codereview.chromium.org/20254/diff/17/19
File net/base/sdch_manager.cc (right):

http://codereview.chromium.org/20254/diff/17/19#newcode367
Line 367: A dictionary is invalid and must not be stored if any of the following
are
Nit: Use C++ comment delimiter // for this block comment.

http://codereview.chromium.org/20254/diff/17/23
File net/url_request/url_request_http_job.h (right):

http://codereview.chromium.org/20254/diff/17/23#newcode84
Line 84: // URL for SDCH dictionary that was suggested in the HTTP header.
Nit: would be nice to say it's the Get-Dictionary HTTP header.

[jar (doing other things), 2009-02-11 21:26:59]

http://codereview.chromium.org/20254/diff/17/19
File net/base/sdch_manager.cc (right):

http://codereview.chromium.org/20254/diff/17/19#newcode367
Line 367: A dictionary is invalid and must not be stored if any of the following
are
On 2009/02/11 19:38:30, wtc wrote:
> Nit: Use C++ comment delimiter // for this block comment.

I tried to make these direct quotes from the SDCH proposed for the spec stand
out, and that is why they appear in this block comment format.

I could change it... but it seemed useful in this context.

http://codereview.chromium.org/20254/diff/17/23
File net/url_request/url_request_http_job.h (right):

http://codereview.chromium.org/20254/diff/17/23#newcode84
Line 84: // URL for SDCH dictionary that was suggested in the HTTP header.
On 2009/02/11 19:38:30, wtc wrote:
> Nit: would be nice to say it's the Get-Dictionary HTTP header.

Done.

[Lincoln, 2009-02-17 21:43:50]

http://codereview.chromium.org/20254/diff/1027/1028
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/20254/diff/1027/1028#newcode68
Line 68: SdchManager::Global()->FetchDictionary(sdch_dictionary_url_);
Could this cause a crash if, when the browser is shut down, there is a pending
URLRequestHttpJob and the destructor for the global SdchManager is called before
the destructor for the URLRequestHttpJob?

http://codereview.chromium.org/20254/diff/1027/1033
File net/url_request/url_request_http_job.h (right):

http://codereview.chromium.org/20254/diff/1027/1033#newcode85
Line 85: GURL sdch_dictionary_url_;
Since you're using GURL, you might want to add:
#include "googleurl/src/gurl.h"