Issue 20251: Extend the IOBuffer to the disk cache....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20251: Extend the IOBuffer to the disk cache.... (Closed)

Created:
11 years, 10 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Extend the IOBuffer to the disk cache. This is cleanup from bug 5325. Original code review: http://codereview.chromium.org/20134/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9626

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+340 lines, -277 lines)			Patch
M	net/base/completion_callback.h	View		3 chunks	+0 lines, -17 lines	0 comments	Download
M	net/base/io_buffer.h	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View		8 chunks	+35 lines, -29 lines	0 comments	Download
M	net/disk_cache/disk_cache.h	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	net/disk_cache/disk_cache_perftest.cc	View		5 chunks	+16 lines, -14 lines	0 comments	Download
M	net/disk_cache/entry_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/entry_impl.cc	View	1	10 chunks	+17 lines, -10 lines	0 comments	Download
M	net/disk_cache/entry_unittest.cc	View	1	22 chunks	+197 lines, -154 lines	0 comments	Download
M	net/disk_cache/mem_entry_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/mem_entry_impl.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	net/disk_cache/stress_cache.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	net/http/http_cache.cc	View		10 chunks	+14 lines, -19 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/http/http_transaction.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/http/http_transaction_unittest.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/dump_cache/upgrade.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	net/url_request/url_request_view_cache_job.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

The delta between patch set 1 and patch set 2 is what I'm adding to ...

11 years, 10 months ago (2009-02-11 18:53:30 UTC) #1

LGTM

Expand Messages | Collapse Messages