Issue 2024007: Dev Server: Require Memento Updater

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2024007: Dev Server: Require Memento Updater (Closed)

Created:
10 years, 7 months ago by adlr

Modified:
9 years ago

Reviewers:
seano

CC:
chromium-os-reviews_chromium.org, dneiss, adlr

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Dev Server: Require Memento Updater Memento Updater: transmit new updaterversion tag so update server know which update client this is.

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
M	src/platform/dev/autoupdate.py	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	src/platform/dev/devserver.py	View	2 chunks	+6 lines, -0 lines	1 comment	Download
M	src/platform/memento_softwareupdate/ping_omaha.sh	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

seano

lgtm++ http://codereview.chromium.org/2024007/diff/1/2 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/2024007/diff/1/2#newcode253 src/platform/dev/autoupdate.py:253: if root.getAttribute('updaterversion') and \ nit: if root.hasAttribute('updaterversion') http://codereview.chromium.org/2024007/diff/1/3 ...

10 years, 7 months ago (2010-05-07 23:23:16 UTC) #2

adlr

10 years, 7 months ago (2010-05-08 00:11:22 UTC) #3

Thanks. fixed and submitted.

On Fri, May 7, 2010 at 4:23 PM, <seano@chromium.org> wrote:

> lgtm++
>
>
> http://codereview.chromium.org/2024007/diff/1/2
> File src/platform/dev/autoupdate.py (right):
>
> http://codereview.chromium.org/2024007/diff/1/2#newcode253
> src/platform/dev/autoupdate.py:253: if
> root.getAttribute('updaterversion') and \
> nit: if root.hasAttribute('updaterversion')'
>

DOne.


>
> http://codereview.chromium.org/2024007/diff/1/3
> File src/platform/dev/devserver.py (right):
>
> http://codereview.chromium.org/2024007/diff/1/3#newcode65
> src/platform/dev/devserver.py:65: if '--client_prefix' in sys.argv:
> why not 'if options.client_prefix' ?
>
>
b/c there's a default value. So even if options.client_prefix is True, that
doesn't necessarily mean it's in sys.argv.


> (I'd like to find a nicer way of cleaning up argv anyway, so I'll rip
> this stuff out eventually.)
>
>
> http://codereview.chromium.org/2024007/show
>

Expand Messages | Collapse Messages