Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2023006: Add /etc/init.d to INSTALL_MASK (Closed)

Created:
10 years, 7 months ago by Olof Johansson
Modified:
9 years, 7 months ago
Reviewers:
tedbo
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromiumos
Visibility:
Public.

Description

Add /etc/init.d to INSTALL_MASK Since we're using upstart, don't let packages drop startup scripts into /etc/init.d. BUG=none TEST=Build image, inspect contents of /etc/init.d (or lack thereof, after this patch)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scripts/common.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Olof Johansson
10 years, 7 months ago (2010-05-10 14:28:43 UTC) #1
tedbo
LGTM I'm assuming that you've tested it. Nothing should be used from /etc/init.d/ but the ...
10 years, 7 months ago (2010-05-10 17:40:08 UTC) #2
Olof Johansson
Right, I built and booted a usb stick without problem. Searching around, I found two ...
10 years, 7 months ago (2010-05-10 20:18:29 UTC) #3
tedbo
10 years, 7 months ago (2010-05-10 20:49:33 UTC) #4
LGTM

Thanks!

ted

On Mon, May 10, 2010 at 1:18 PM,  <olofj@chromium.org> wrote:
> Right, I built and booted a usb stick without problem.
>
> Searching around, I found two references to files in /etc/init.d that seemed
> relevant:
>
> 1) logrotate uses it to reload syslogd. I opened issue 3133 for this, and
> kmixter chimed in to say logrotate is still on the todo list in the first
> place.
>
> 2) There's quite a few scripts sourcing /etc/init.d/functions.sh (some
> saying
> "for colors"). We're already not shipping that file as-is.
>
> The rest seems to mostly be cruft, a handful of scripts reference the
> directory
> (or rather scripts in it), but I didn't spot anything that seemed relevant.
>
>
> http://codereview.chromium.org/2023006/show
>

Powered by Google App Engine
This is Rietveld 408576698