One element cache for localtime.

One element cache for localtime.

Committed: http://code.google.com/p/v8/source/detail?r=4628

[sandholm, 2010-05-10 07:44:43]

Lasse, would you have a look? Thx, Anders

[Lasse Reichstein, 2010-05-10 08:40:20]

LGTM.

[Lasse Reichstein, 2010-05-10 09:06:28]

http://codereview.chromium.org/2023005/diff/1/2
File src/date.js (right):

http://codereview.chromium.org/2023005/diff/1/2#newcode249
src/date.js:249: if (time == ltc.key) return ltc.val;
On second thought, use
 if (%_ObjectEquals(time, ltc.key)) return ltc.val;
The comparison is faster, and should work just as well in this case.
The key is likely to be a HeapNumber, and this cache only makes sense when you
do several calls on the same Date object, and they will also have the same
HeapNumber as time value.

[sandholm, 2010-05-10 09:27:09]

http://codereview.chromium.org/2023005/diff/1/2
File src/date.js (right):

http://codereview.chromium.org/2023005/diff/1/2#newcode249
src/date.js:249: if (time == ltc.key) return ltc.val;
On 2010/05/10 09:06:28, Lasse Reichstein wrote:
> On second thought, use
>  if (%_ObjectEquals(time, ltc.key)) return ltc.val;
> The comparison is faster, and should work just as well in this case.
> The key is likely to be a HeapNumber, and this cache only makes sense when you
> do several calls on the same Date object, and they will also have the same
> HeapNumber as time value.

Done.