Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 202054: Add {release,debug}_extra_cflags for mac and linux (Closed)

Created:
11 years, 3 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, stuartmorgan, Timur Iskhodzhanov
Visibility:
Public.

Description

There was already release_extra_cflags for linux; this just generalizes it to debug_ and to mac. Required a litle rearranging. Tested by comparing xcode and make files before and after change. Ignores those settings when generating Visual C++ projects, but since the goal was to let valgrind bots tweak optimization settings, that's ok for now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25997

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M build/common.gypi View 1 2 7 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dank
(Avoided adding new platform specific variables, but didn't clean up any of the old ones.)
11 years, 3 months ago (2009-09-11 17:26:52 UTC) #1
Mark Mentovai
11 years, 3 months ago (2009-09-11 17:32:25 UTC) #2
lg otherwise

http://codereview.chromium.org/202054/diff/2001/3001
File build/common.gypi (right):

http://codereview.chromium.org/202054/diff/2001/3001#newcode171
Line 171: 'release_extra_cflags%':   '',
Don't put all of that extra space, we don't do that elsewhere.

http://codereview.chromium.org/202054/diff/2001/3001#newcode236
Line 236: 'OTHER_CFLAGS': '<(debug_extra_cflags)',
I think this should be ['<@(debug_extra_cflags)'] as is done for Linux.  Same
for release.

http://codereview.chromium.org/202054/diff/2001/3001#newcode263
Line 263: '<@(debug_extra_cflags)',
Indent is wrong.  Same for release.

Powered by Google App Engine
This is Rietveld 408576698