Issue 202049: Adding the option to drop in a new BrowserDistribution instance for experimen...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202049: Adding the option to drop in a new BrowserDistribution instance for experimen... (Closed)

Created:
11 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding the option to drop in a new BrowserDistribution instance for experimentation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25950

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1 line)			Patch
M	build/common.gypi	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/installer/installer.gyp	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kuchhal

lgtm. http://codereview.chromium.org/202049/diff/1/5 File chrome/installer/util/google_chrome_distribution.h (right): http://codereview.chromium.org/202049/diff/1/5#newcode113 Line 113: protected: as discussed offline this might not ...

11 years, 3 months ago (2009-09-10 21:54:29 UTC) #2

robertshield

11 years, 3 months ago (2009-09-10 23:17:19 UTC) #3

Thanks!

http://codereview.chromium.org/202049/diff/1/5
File chrome/installer/util/google_chrome_distribution.h (right):

http://codereview.chromium.org/202049/diff/1/5#newcode113
Line 113: protected:
On 2009/09/10 21:54:29, kuchhal wrote:
> as discussed offline this might not be needed at all.

Done.

Expand Messages | Collapse Messages

Issue 202049: Adding the option to drop in a new BrowserDistribution instance for experimen... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages