Issue 202044: Add exe servers to the list of binaries that may be packaged with the mini_in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202044: Add exe servers to the list of binaries that may be packaged with the mini_in... (Closed)

Created:
11 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal, ananta

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add exe servers to the list of binaries that may be packaged with the mini_installer. Does not cause them to be registered. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25871

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	chrome/installer/mini_installer/chrome.release	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/tools/build/win/scan_server_dlls.py	View		2 chunks	+21 lines, -10 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kuchhal

drive by nit below. otherwise lgtm. http://codereview.chromium.org/202044/diff/1/3 File chrome/tools/build/win/scan_server_dlls.py (right): http://codereview.chromium.org/202044/diff/1/3#newcode80 Line 80: old_file.close() here ...

11 years, 3 months ago (2009-09-10 17:08:23 UTC) #3

robertshield

11 years, 3 months ago (2009-09-10 17:30:46 UTC) #4

http://codereview.chromium.org/202044/diff/1/3
File chrome/tools/build/win/scan_server_dlls.py (right):

http://codereview.chromium.org/202044/diff/1/3#newcode80
Line 80: 
On 2009/09/10 17:08:23, kuchhal wrote:
> old_file.close() here somewhere

Added, thanks!

Expand Messages | Collapse Messages