Issue 202035: Fix accel leak in task manager and bookmark manager by using

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202035: Fix accel leak in task manager and bookmark manager by using (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins, mattm

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix accel leak in task manager and bookmark manager by using the same cleanup code as browser_window_gtk. Also fix a leak of the gtk widgets when the accelerator was not used for the task manager. If the user closed by using the window manager destroy, then we never called gtk_widget_destroy on the window and leaked the widgets.

Patch Set 1 #

Total comments: 1

Patch Set 2 : null #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
M	chrome/browser/gtk/bookmark_manager_gtk.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/task_manager_gtk.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/task_manager_gtk.cc	View		3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

11 years, 3 months ago (2009-09-10 01:13:21 UTC) #2

lgtm

Ar, weird gtk refcounting stuff strikes again.

http://codereview.chromium.org/202035/diff/1/2
File chrome/browser/gtk/bookmark_manager_gtk.cc (right):

http://codereview.chromium.org/202035/diff/1/2#newcode329
Line 329: accel_group_ = NULL;
setting it to NULL seems unnecessary since this is in the destructor (vs
browser_window_gtk which has it in a close method and uses that as a flag)

Expand Messages | Collapse Messages