Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: webkit/glue/editor_client_impl.cc

Issue 202031: Remove NOTIMPLEMENTED() that messes with layout test output... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The Mac interface forwards most of these commands to the application layer, 5 // The Mac interface forwards most of these commands to the application layer,
6 // and I'm not really sure what to do about most of them. 6 // and I'm not really sure what to do about most of them.
7 7
8 #include "config.h" 8 #include "config.h"
9 9
10 #include "Document.h" 10 #include "Document.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 void EditorClientImpl::toggleGrammarChecking() { 150 void EditorClientImpl::toggleGrammarChecking() {
151 NOTIMPLEMENTED(); 151 NOTIMPLEMENTED();
152 } 152 }
153 153
154 int EditorClientImpl::spellCheckerDocumentTag() { 154 int EditorClientImpl::spellCheckerDocumentTag() {
155 #if defined(OS_MACOSX) 155 #if defined(OS_MACOSX)
156 WebViewDelegate* d = web_view_->delegate(); 156 WebViewDelegate* d = web_view_->delegate();
157 if (d) 157 if (d)
158 return d->SpellCheckerDocumentTag(); 158 return d->SpellCheckerDocumentTag();
159 #else 159 #else
160 NOTIMPLEMENTED(); 160 // Can't use NOTIMPLEMENTED() here as it confounds the layout test output,
161 // but this should eventually be implemented for ignores to work.
161 #endif // OS_MACOSX 162 #endif // OS_MACOSX
162 return 0; 163 return 0;
163 } 164 }
164 165
165 bool EditorClientImpl::isEditable() { 166 bool EditorClientImpl::isEditable() {
166 return false; 167 return false;
167 } 168 }
168 169
169 bool EditorClientImpl::shouldBeginEditing(WebCore::Range* range) { 170 bool EditorClientImpl::shouldBeginEditing(WebCore::Range* range) {
170 if (editing_client_) { 171 if (editing_client_) {
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 922
922 void EditorClientImpl::getGuessesForWord(const WebCore::String&, 923 void EditorClientImpl::getGuessesForWord(const WebCore::String&,
923 WTF::Vector<WebCore::String>& guesses) { 924 WTF::Vector<WebCore::String>& guesses) {
924 NOTIMPLEMENTED(); 925 NOTIMPLEMENTED();
925 } 926 }
926 927
927 void EditorClientImpl::setInputMethodState(bool enabled) { 928 void EditorClientImpl::setInputMethodState(bool enabled) {
928 if (editing_client_) 929 if (editing_client_)
929 editing_client_->setInputMethodEnabled(enabled); 930 editing_client_->setInputMethodEnabled(enabled);
930 } 931 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698