src/log.cc - Issue 202018: Heap profiler: account primitive string objects as being constructed using 'String'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 202018: Heap profiler: account primitive string objects as being constructed using 'String'. (Closed)

Patch Set: Fixed comments Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 56808202add7186a395403310fb00df07a72567e..6bbefbceb142f4924c58d869688f1e91f08e3bf7 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -890,9 +890,7 @@ void Logger::HeapSampleJSConstructorEvent(const char* constructor,

if (!Log::IsEnabled() || !FLAG_log_gc) return;

LogMessageBuilder msg;

msg.Append("heap-js-cons-item,%s,%d,%d\n",

- constructor != NULL ?

- (constructor[0] != '\0' ? constructor : "(anonymous)") :

- "(no_constructor)",

+ constructor[0] != '\0' ? constructor : "(anonymous)",

number, bytes);

msg.WriteToLogFile();

#endif

« no previous file with comments | « src/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »