Heap profiler: account primitive string objects as being constructed using 'String'.

Heap profiler: account primitive string objects as being constructed using 'String'.

Also:
- move constructor name getter near similar class name getter method;
- if the constructor is not present, use 'Object', as for class name, this eliminates a special case.

Committed: http://code.google.com/p/v8/source/detail?r=2859

[Søren Thygesen Gjesse, 2009-09-09 11:31:37]

LGTM with comments.

http://codereview.chromium.org/202018/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/202018/diff/1/2#newcode3607
Line 3607: String* constructor_func = NULL;
constructor_func -> constructor_name?

http://codereview.chromium.org/202018/diff/1/2#newcode3608
Line 3608: int size = obj->Size();
Move size = obj->Size() to the first if part as this is where it actually
counts.

http://codereview.chromium.org/202018/diff/1/2#newcode3610
Line 3610: constructor_func = Heap::String_symbol();
Using obj->Size() for strings is to simple in many cases, but we can iterate
over that. Also maybe we should do something special for external strings.

http://codereview.chromium.org/202018/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/202018/diff/1/4#newcode1200
Line 1200: if (IsJSFunction()) return Heap::function_class_symbol();
Please place this return on a separate line and add {}'s.

[mnaganov (inactive), 2009-09-09 11:38:08]

Thanks!

http://codereview.chromium.org/202018/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/202018/diff/1/2#newcode3607
Line 3607: String* constructor_func = NULL;
On 2009/09/09 11:31:37, Søren Gjesse wrote:
> constructor_func -> constructor_name?

'constructor' is enough. Fixed.

http://codereview.chromium.org/202018/diff/1/2#newcode3608
Line 3608: int size = obj->Size();
On 2009/09/09 11:31:37, Søren Gjesse wrote:
> Move size = obj->Size() to the first if part as this is where it actually
> counts.

Done.

http://codereview.chromium.org/202018/diff/1/2#newcode3610
Line 3610: constructor_func = Heap::String_symbol();
On 2009/09/09 11:31:37, Søren Gjesse wrote:
> Using obj->Size() for strings is to simple in many cases, but we can iterate
> over that. Also maybe we should do something special for external strings.

Right now it resembles HeapProfiler::CollectStats used for calculation of
internal types statistics. Yes, I think there is a room for improvement.

http://codereview.chromium.org/202018/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/202018/diff/1/4#newcode1200
Line 1200: if (IsJSFunction()) return Heap::function_class_symbol();
On 2009/09/09 11:31:37, Søren Gjesse wrote:
> Please place this return on a separate line and add {}'s.

Done. Also for the 'class_name' method above.