Issue 202012: linux: build a fake libxul and libxpcom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202012: linux: build a fake libxul and libxpcom (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
agl, piman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: build a fake libxul and libxpcom This makes some plugins happy. As described in the file comments, this approach is also used by nspluginwrapper.

Patch Set 1 #

Patch Set 2 : with new file #

Patch Set 3 : works #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -10 lines)			Patch
M	base/native_library_linux.cc	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	1 comment	Download
A	webkit/tools/libxul_hack/libxul_hack.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 2	2 chunks	+28 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

piman

11 years, 3 months ago (2009-09-08 20:51:22 UTC) #2

LGTM globally.

One question: how do these lib get put in the LD_LIBRARY_PATH ?

http://codereview.chromium.org/202012/diff/3001/3003
File chrome/chrome.gyp (right):

http://codereview.chromium.org/202012/diff/3001/3003#newcode2185
Line 2185: '../webkit/webkit.gyp:xul',    # Not what it looks like! See
I don't know... what does it look like ? :)

I'd rather put a comment like "build placeholder libraries, see webkit.gyp for
details"

Expand Messages | Collapse Messages