Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 202008: Change to limit the amount of space we waste due to fragmentation ... (Closed)

Created:
11 years, 3 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change to limit the amount of space we waste due to fragmentation in old space. Before this change we would compute the fragmentation limit before the GC, but that means that we take all the garbage into account - and consequently we almost never hit the limit (because we have a lot of garbage). This change changes the policy to compact on the *next* GC if we determine that we have too much fragmentation after doing a GC. We'll do a GC if we've wasted more than 1MB and more than 15% of the old space size. This can be further improved by computing whether or not to compact during the marking phase. Committed: http://code.google.com/p/v8/source/detail?r=2841

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/mark-compact.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 3 chunks +29 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years, 3 months ago (2009-09-08 06:35:16 UTC) #1
Mads Ager (chromium)
11 years, 3 months ago (2009-09-08 07:05:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698