Issue 202004: Move common enums for macro assemblers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202004: Move common enums for macro assemblers (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move common enums for macro assemblers. All macro-assembler-*.cc used a number of common enums. Moved these to macro-assembler.h. Removed unused enum ExitJSFlag from ARM macro assembler. Committed: http://code.google.com/p/v8/source/detail?r=2836

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -97 lines)			Patch
M	src/arm/macro-assembler-arm.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	src/macro-assembler.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

On 2009/09/07 10:50:07, Erik Corry wrote: > LGTM > > We weren't using ExitJSFlag anywhere? ...

11 years, 3 months ago (2009-09-07 11:00:32 UTC) #4

LGTM too.

Expand Messages | Collapse Messages