chrome/installer/util/create_dir_work_item_unittest.cc - Issue 202002: Replaces the windows function CreateDirectory with the CreateDirectory method...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/create_dir_work_item_unittest.cc

Issue 202002: Replaces the windows function CreateDirectory with the CreateDirectory method... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/copy_tree_work_item_unittest.cc ('k') | chrome/installer/util/delete_tree_work_item_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/create_dir_work_item_unittest.cc

===================================================================

--- chrome/installer/util/create_dir_work_item_unittest.cc (revision 25594)

+++ chrome/installer/util/create_dir_work_item_unittest.cc (working copy)

@@ -39,7 +39,7 @@

TEST_F(CreateDirWorkItemTest, CreatePath) {

FilePath parent_dir(test_dir_);

parent_dir = parent_dir.AppendASCII("a");

- CreateDirectory(parent_dir.value().c_str(), NULL);

+ file_util::CreateDirectory(parent_dir);

ASSERT_TRUE(file_util::PathExists(parent_dir));

FilePath top_dir_to_create(parent_dir);

@@ -66,7 +66,7 @@

TEST_F(CreateDirWorkItemTest, CreateExistingPath) {

FilePath dir_to_create(test_dir_);

dir_to_create = dir_to_create.AppendASCII("aa");

- CreateDirectory(dir_to_create.value().c_str(), NULL);

+ file_util::CreateDirectory(dir_to_create);

ASSERT_TRUE(file_util::PathExists(dir_to_create));

scoped_ptr<CreateDirWorkItem> work_item(

@@ -103,7 +103,7 @@

// Create another directory under dir_to_create_2

FilePath dir_to_create_4(dir_to_create_2);

dir_to_create_4 = dir_to_create_4.AppendASCII("ddd");

- CreateDirectory(dir_to_create_4.value().c_str(), NULL);

+ file_util::CreateDirectory(dir_to_create_4);

ASSERT_TRUE(file_util::PathExists(dir_to_create_4));

work_item->Rollback();

« no previous file with comments | « chrome/installer/util/copy_tree_work_item_unittest.cc ('k') | chrome/installer/util/delete_tree_work_item_unittest.cc » ('j') | no next file with comments »