Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4352)

Unified Diff: chrome/installer/util/helper_unittest.cc

Issue 202002: Replaces the windows function CreateDirectory with the CreateDirectory method... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/helper_unittest.cc
===================================================================
--- chrome/installer/util/helper_unittest.cc (revision 25594)
+++ chrome/installer/util/helper_unittest.cc (working copy)
@@ -61,27 +61,27 @@
// Create a Chrome dir
FilePath chrome_dir(test_dir_);
chrome_dir = chrome_dir.AppendASCII("chrome");
- CreateDirectory(chrome_dir.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir);
ASSERT_TRUE(file_util::PathExists(chrome_dir));
FilePath chrome_dir_1(chrome_dir);
chrome_dir_1 = chrome_dir_1.AppendASCII("1.0.1.0");
- CreateDirectory(chrome_dir_1.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_1);
ASSERT_TRUE(file_util::PathExists(chrome_dir_1));
FilePath chrome_dir_2(chrome_dir);
chrome_dir_2 = chrome_dir_2.AppendASCII("1.0.2.0");
- CreateDirectory(chrome_dir_2.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_2);
ASSERT_TRUE(file_util::PathExists(chrome_dir_2));
FilePath chrome_dir_3(chrome_dir);
chrome_dir_3 = chrome_dir_3.AppendASCII("1.0.3.0");
- CreateDirectory(chrome_dir_3.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_3);
ASSERT_TRUE(file_util::PathExists(chrome_dir_3));
FilePath chrome_dir_4(chrome_dir);
chrome_dir_4 = chrome_dir_4.AppendASCII("1.0.4.0");
- CreateDirectory(chrome_dir_4.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_4);
ASSERT_TRUE(file_util::PathExists(chrome_dir_4));
FilePath chrome_dll_1(chrome_dir_1);
@@ -120,27 +120,27 @@
// Create a Chrome dir
FilePath chrome_dir(test_dir_);
chrome_dir = chrome_dir.AppendASCII("chrome");
- CreateDirectory(chrome_dir.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir);
ASSERT_TRUE(file_util::PathExists(chrome_dir));
FilePath chrome_dir_1(chrome_dir);
chrome_dir_1 = chrome_dir_1.AppendASCII("1.0.1.0");
- CreateDirectory(chrome_dir_1.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_1);
ASSERT_TRUE(file_util::PathExists(chrome_dir_1));
FilePath chrome_dir_2(chrome_dir);
chrome_dir_2 = chrome_dir_2.AppendASCII("1.0.2.0");
- CreateDirectory(chrome_dir_2.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_2);
ASSERT_TRUE(file_util::PathExists(chrome_dir_2));
FilePath chrome_dir_3(chrome_dir);
chrome_dir_3 = chrome_dir_3.AppendASCII("1.0.3.0");
- CreateDirectory(chrome_dir_3.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_3);
ASSERT_TRUE(file_util::PathExists(chrome_dir_3));
FilePath chrome_dir_4(chrome_dir);
chrome_dir_4 = chrome_dir_4.AppendASCII("1.0.4.0");
- CreateDirectory(chrome_dir_4.value().c_str(), NULL);
+ file_util::CreateDirectory(chrome_dir_4);
ASSERT_TRUE(file_util::PathExists(chrome_dir_4));
FilePath chrome_dll_1(chrome_dir_1);
« no previous file with comments | « chrome/installer/util/delete_tree_work_item_unittest.cc ('k') | chrome/installer/util/move_tree_work_item_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698