Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2019008: Dev flag is not used in customize_rootfs and we should not be making dev-specific changes there. (Closed)

Created:
10 years, 7 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

Dev flag is not used in customize_rootfs and we should not be making dev-specific changes there. TEST=Built an image

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/scripts/build_image View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
10 years, 7 months ago (2010-05-10 22:46:18 UTC) #1
Chris Masone
I always like code deletion CLs :-)
10 years, 7 months ago (2010-05-10 22:53:49 UTC) #2
Chris Masone
10 years, 7 months ago (2010-05-10 22:54:04 UTC) #3
On 2010/05/10 22:53:49, cmasone wrote:
> I always like code deletion CLs :-)

uh, so, LGTM.  yes

Powered by Google App Engine
This is Rietveld 408576698