Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Side by Side Diff: src/debug-ia32.cc

Issue 20176: Moved some IA32 specific code from to the architecture dependent part of the ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug-arm.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 16 matching lines...) Expand all
27 27
28 #include "v8.h" 28 #include "v8.h"
29 29
30 #include "codegen-inl.h" 30 #include "codegen-inl.h"
31 #include "debug.h" 31 #include "debug.h"
32 32
33 33
34 namespace v8 { namespace internal { 34 namespace v8 { namespace internal {
35 35
36 36
37 // A debug break in the frame exit code is identified by a call instruction.
38 bool BreakLocationIterator::IsDebugBreakAtReturn() {
39 // Opcode E8 is call.
40 return (*(rinfo()->pc()) == 0xE8);
41 }
42
43
44 // Patch the JS frame exit code with a debug break call. See
45 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-ia32.cc
46 // for the precise return instructions sequence.
47 void BreakLocationIterator::SetDebugBreakAtReturn() {
48 ASSERT(Debug::kIa32JSReturnSequenceLength >=
49 Debug::kIa32CallInstructionLength);
50 rinfo()->PatchCodeWithCall(Debug::debug_break_return_entry()->entry(),
51 Debug::kIa32JSReturnSequenceLength - Debug::kIa32CallInstructionLength);
52 }
53
54
55 // Restore the JS frame exit code.
56 void BreakLocationIterator::ClearDebugBreakAtReturn() {
57 rinfo()->PatchCode(original_rinfo()->pc(),
58 Debug::kIa32JSReturnSequenceLength);
59 }
60
61
37 #define __ masm-> 62 #define __ masm->
38 63
39 64
40 static void Generate_DebugBreakCallHelper(MacroAssembler* masm, 65 static void Generate_DebugBreakCallHelper(MacroAssembler* masm,
41 RegList pointer_regs, 66 RegList pointer_regs,
42 bool convert_call_to_jmp) { 67 bool convert_call_to_jmp) {
43 // Save the content of all general purpose registers in memory. This copy in 68 // Save the content of all general purpose registers in memory. This copy in
44 // memory is later pushed onto the JS expression stack for the fake JS frame 69 // memory is later pushed onto the JS expression stack for the fake JS frame
45 // generated and also to the C frame generated on top of that. In the JS 70 // generated and also to the C frame generated on top of that. In the JS
46 // frame ONLY the registers containing pointers will be pushed on the 71 // frame ONLY the registers containing pointers will be pushed on the
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // No registers used on entry. 201 // No registers used on entry.
177 // ----------------------------------- 202 // -----------------------------------
178 Generate_DebugBreakCallHelper(masm, 0, false); 203 Generate_DebugBreakCallHelper(masm, 0, false);
179 } 204 }
180 205
181 206
182 #undef __ 207 #undef __
183 208
184 209
185 } } // namespace v8::internal 210 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug-arm.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698