Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 20174: Remove LIBS_DIR usage. (Closed)

Created:
11 years, 10 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove LIBS_DIR usage. It doesn't seem to occur anywhere in the SCons code nor in ours(?).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/SConscript.main View 1 chunk +0 lines, -3 lines 0 comments Download
M build/SConscript.v8 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/SConscript View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
feel free to suggest someone else to review if you think appropriate
11 years, 10 months ago (2009-02-09 07:59:04 UTC) #1
tony
11 years, 10 months ago (2009-02-09 18:47:04 UTC) #2
LGTM.  Does LIB_DIR get defined by scons automatically?

Powered by Google App Engine
This is Rietveld 408576698