Correct issue 696 with Date.parse returning a value when called on a non date...

Correct issue 696 with Date.parse returning a value when called on a non date string.

The error was introduced in revision 4557 where support was added for
ES5 date time format strings. Because there was no check for a valid
year a random string starting with a non-digit character would be
parsed.

This change disallows ES5 formatted dates where there is no date
fraction (i.e., with only a timestamp). Since none of the other
browsers support Date.parse on only timestamps I have disabled this
totally instead of just correcting the parser.



Committed: http://code.google.com/p/v8/source/detail?r=4613

[Rico, 2010-05-07 10:42:13]

I discussed quite a bit with lasse about how to best support Date.parse on
timestamps only. The problem is that the spec is not specific on this. I states
that one should accept strings that conform to 15.9.1.15, but leaves out how to
handle timestamp only values. There is a number of solutions:
The date part defaults to today
The date part defaults to 2000-01-01
The date part defaults to 1970-01-01 (probably best solution - but we might
break compatibility with other browsers)

[Lasse Reichstein, 2010-05-07 11:21:59]

LGTM.

http://codereview.chromium.org/2017005/diff/1/2
File src/dateparser.cc (right):

http://codereview.chromium.org/2017005/diff/1/2#newcode47
src/dateparser.cc:47: if (index_ < 2) return false;
Drop this test.

[Rico, 2010-05-07 11:35:55]

Added regression test, please take another look

http://codereview.chromium.org/2017005/diff/1/2
File src/dateparser.cc (right):

http://codereview.chromium.org/2017005/diff/1/2#newcode47
src/dateparser.cc:47: if (index_ < 2) return false;
On 2010/05/07 11:21:59, Lasse Reichstein wrote:
> Drop this test.

Done.

[Rico, 2010-05-07 11:35:56]

Added regression test, please take another look

[Lasse Reichstein, 2010-05-07 11:39:08]

LGTM, if you put in a comment that the current behavior isn't ES5 compliant.