Issue 2017002: Turn {mov,add}q into {mov,add}l.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2017002: Turn {mov,add}q into {mov,add}l. (Closed)

Created:
10 years, 7 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Turn {mov,add}q into {mov,add}l. All the cases fixed are safe as registers hold 32-bit value, but that looks safer to operate on proper sizes. Committed: http://code.google.com/p/v8/source/detail?r=4610

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/x64/codegen-x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/x64/stub-cache-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Lasse, may you have a look? I am not quite versed in x64 ways and ...

10 years, 7 months ago (2010-05-06 17:37:11 UTC) #1

Lasse Reichstein

10 years, 7 months ago (2010-05-07 06:56:42 UTC) #2

LGTM, and if anything it could make things faster (the instructions are one byte
shorter).
It's pure luck that it has worked so far. There is an unused 32-bit hole after
the length field of Arrays on X64, and we were overwriting it unnecessarily. If
the hole had been used for anything, like it used to be on strings, it would
have been a problem.

Expand Messages | Collapse Messages