POSIX: basic IPC logging

POSIX: basic IPC logging

For the moment, we enable IPC logging with an environment variable
(CHROME_IPC_LOGGING) and log everything to stderr.

[Evan Martin, 2009-02-07 00:25:17]

LGTM

http://codereview.chromium.org/20156/diff/1/4
File chrome/common/ipc_logging.cc (right):

http://codereview.chromium.org/20156/diff/1/4#newcode86
Line 86: if (getenv("CHROME_IPC_LOGGING"))
maybe stick a TODO(port) in

http://codereview.chromium.org/20156/diff/1/5
File chrome/common/ipc_logging.h (right):

http://codereview.chromium.org/20156/diff/1/5#newcode86
Line 86: base::WaitableEventWatcher watcher_;
I am sad that nobody documents member variables.

[jam, 2009-02-07 00:30:38]

lgtm, some nits

http://codereview.chromium.org/20156/diff/1/4
File chrome/common/ipc_logging.cc (right):

http://codereview.chromium.org/20156/diff/1/4#newcode53
Line 53: consumer_(NULL) {
while you're touching this, why not make it alphabetically ordered?

http://codereview.chromium.org/20156/diff/1/4#newcode230
Line 230: #if defined(OS_WIN)
nit: perhaps the ifdefs can move inside the function?

http://codereview.chromium.org/20156/diff/1/5
File chrome/common/ipc_logging.h (right):

http://codereview.chromium.org/20156/diff/1/5#newcode67
Line 67: // ObjectWatcher::Delegate implementation
nit: update comment

[stoyan, 2009-02-07 01:07:15]

http://codereview.chromium.org/20156/diff/1/5
File chrome/common/ipc_logging.h (right):

http://codereview.chromium.org/20156/diff/1/5#newcode89
Line 89: scoped_ptr<base::WaitableEvent> logging_event_off_;
Are these really have to be in the heap? 
I see we need named events on Windows but WaitableEvent does not seem to support
attaching to a handle. so perhaps a fix to WaitableEvent too?

[agl, 2009-02-10 01:06:57]

http://codereview.chromium.org/20156/diff/1/4
File chrome/common/ipc_logging.cc (right):

http://codereview.chromium.org/20156/diff/1/4#newcode53
Line 53: consumer_(NULL) {
On 2009/02/07 00:30:38, John Abd-El-Malek wrote:
> while you're touching this, why not make it alphabetically ordered?

They have to be in decl order, that's why I was reordering them ;)

http://codereview.chromium.org/20156/diff/1/5
File chrome/common/ipc_logging.h (right):

http://codereview.chromium.org/20156/diff/1/5#newcode67
Line 67: // ObjectWatcher::Delegate implementation
On 2009/02/07 00:30:38, John Abd-El-Malek wrote:
> nit: update comment

Done.

[agl, 2009-02-10 02:00:24]

awalker: By adding the logging functions to ipc_logging.cc I've brought them
into the realm of ipc_tests. If you look at the changes I made to
ipc_tests.scons, you can see the additional libraries which were needed. If you
could help me add them to the OSX build, that would be great; thanks.

[Amanda Walker, 2009-02-10 18:46:14]

On 2009/02/10 02:00:24, agl wrote:
> If you could help me add them to the OSX build, that would be great; thanks.

Will do--looks pretty straightforward.