Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2014012: Don't ask to upload a stack trace anymore. (Closed)

Created:
10 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Don't ask to upload a stack trace anymore. The code proved to be robust enough to not do false positive, i.e. no non-googler stack trace has been uploaded up to date. So stop wasting users time and just do it. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M breakpad.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 7 months ago (2010-05-11 20:06:17 UTC) #1
jam
10 years, 7 months ago (2010-05-11 21:09:19 UTC) #2
lgtm

On Tue, May 11, 2010 at 1:06 PM, <maruel@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Don't ask to upload a stack trace anymore.
>
> The code proved to be robust enough to not do false positive, i.e.
> no non-googler stack trace has been uploaded up to date.
> So stop wasting users time and just do it.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/2014012/show
>
> Affected files:
>  M breakpad.py
>
>
> Index: breakpad.py
> diff --git a/breakpad.py b/breakpad.py
> index
>
ff81d05489b1e0b81e3d3857bd74cd33fd6a222c..2d662d7e700ddda7827aa0c5c550c340733f7375
> 100644
> --- a/breakpad.py
> +++ b/breakpad.py
> @@ -15,9 +15,6 @@ import sys
>
>
>  def SendStack(stack, url='http://chromium-status.appspot.com/breakpad'):
> -  print 'Do you want to send a crash report [y/N]? ',
> -  if sys.stdin.read(1).lower() != 'y':
> -    return
>   print 'Sending crash report ...'
>   try:
>     params = {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698