Create AudioRendererHost in BrowserRenderProcessHost and hook with ResourceMessageFilter

Construct AudioRendererHost in BrowserRendererProcessHost, also construct
ResourceMessageFilter with pointer to it so we can delegate requests to it from IPC later.

[Alpha Left Google, 2009-02-06 18:42:33]

Tiny CL just to hook ResourceMessageFilter with AudioRendererHost.

[cpu_(ooo_6.6-7.5), 2009-02-06 21:40:01]

LGTM, one comment:

http://codereview.chromium.org/20131/diff/11/1004
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/20131/diff/11/1004#newcode210
Line 210: AudioRendererHost* audio_renderer_host_;
As a todo we need to verify that the lifetime of the render_process_host is
strictly larger than the resource_message_filer.

[Alpha Left Google, 2009-02-10 02:27:41]

I broke my own DCHECKs in unit tests so I paid more attentions to threading
problems of using AudioRendererHost and AudioManager.

[cpu_(ooo_6.6-7.5), 2009-02-10 22:30:52]

http://codereview.chromium.org/20131/diff/46/1058
File chrome/browser/renderer_host/audio_renderer_host.cc (right):

http://codereview.chromium.org/20131/diff/46/1058#newcode180
Line 180: // Post a post to the thread where this object should live and do the
actual
Post a post?

http://codereview.chromium.org/20131/diff/46/1059
File chrome/browser/renderer_host/audio_renderer_host.h (right):

http://codereview.chromium.org/20131/diff/46/1059#newcode157
Line 157: MessageLoop* message_loop_;
would it be better to call message_loop_  io_messsage_loop_ ? or something to
remind us that it is happening on the io thread?

http://codereview.chromium.org/20131/diff/46/1064
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/20131/diff/46/1064#newcode210
Line 210: AudioRendererHost* audio_renderer_host_;
Given that audio_render_host is a refcounted object, it should be used in all
places as a refcounted scoped_ptr.

Well, maybe not in all cases, but I still think is safer if it is used
everywhere as a scoped_ptr

http://codereview.chromium.org/20131/diff/46/1065
File media/audio/audio_output.h (right):

http://codereview.chromium.org/20131/diff/46/1065#newcode8
Line 8: #include "base/basictypes.h"
why do we need this include here?

[Alpha Left Google, 2009-02-10 22:49:09]

This CL is getting very long..I'm making changes to mac build files so that it
would build.

http://codereview.chromium.org/20131/diff/46/1058
File chrome/browser/renderer_host/audio_renderer_host.cc (right):

http://codereview.chromium.org/20131/diff/46/1058#newcode180
Line 180: // Post a post to the thread where this object should live and do the
actual
On 2009/02/10 22:30:52, cpu wrote:
> Post a post?

Done correcting this comment.

http://codereview.chromium.org/20131/diff/46/1059
File chrome/browser/renderer_host/audio_renderer_host.h (right):

http://codereview.chromium.org/20131/diff/46/1059#newcode157
Line 157: MessageLoop* message_loop_;
On 2009/02/10 22:30:52, cpu wrote:
> would it be better to call message_loop_  io_messsage_loop_ ? or something to
> remind us that it is happening on the io thread?
> 
> 
io_loop_ sounds good to me.

http://codereview.chromium.org/20131/diff/46/1064
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/20131/diff/46/1064#newcode210
Line 210: AudioRendererHost* audio_renderer_host_;
On 2009/02/10 22:30:52, cpu wrote:
> Given that audio_render_host is a refcounted object, it should be used in all
> places as a refcounted scoped_ptr.
> 
> Well, maybe not in all cases, but I still think is safer if it is used
> everywhere as a scoped_ptr
> 
> 

Agreed, then the lifetime of AudioRendererHost will be strictly larger than
ResourceMessageFilter.

http://codereview.chromium.org/20131/diff/46/1065
File media/audio/audio_output.h (right):

http://codereview.chromium.org/20131/diff/46/1065#newcode8
Line 8: #include "base/basictypes.h"
On 2009/02/10 22:30:52, cpu wrote:
> why do we need this include here?

Because this file is using size_t, or else who ever uses this file has to
include "base/basictypes.h"

[Alpha Left Google, 2009-02-10 22:49:14]

This CL is getting very long..I'm making changes to mac build files so that it
would build.

[cpu_(ooo_6.6-7.5), 2009-02-10 23:03:42]

about size_t: 
http://www.cplusplus.com/reference/clibrary/cstring/size_t.html


On 2009/02/10 22:49:14, Alpha wrote:
> This CL is getting very long..I'm making changes to mac build files so that it
> would build.

[cpu_(ooo_6.6-7.5), 2009-02-10 23:06:49]

actually : http://en.wikipedia.org/wiki/Stddef.h

If wchar_t is defined, then size_t should be defined as well.. I don't think you
need an include, or does it complain about both?



On 2009/02/10 23:03:42, cpu wrote:
> about size_t: 
> http://www.cplusplus.com/reference/clibrary/cstring/size_t.html
> 
> 
> On 2009/02/10 22:49:14, Alpha wrote:
> > This CL is getting very long..I'm making changes to mac build files so that
it
> > would build.

[cpu_(ooo_6.6-7.5), 2009-02-11 00:58:52]

LGTM