Remove --omnibox-popup-count flag.

Remove --omnibox-popup-count flag.

BUG=40083
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47482

[tfarina (gmail-do not use), 2010-05-07 02:25:52]

Hi Scott, could you take a look?

[sky, 2010-05-07 14:49:38]

I'm inclined to nuke set_max_matches as well and convert max_matches_ into a
constant. Peter, what do you think?

[Peter Kasting, 2010-05-07 17:42:54]

On 2010/05/07 14:49:38, sky wrote:
> I'm inclined to nuke set_max_matches as well and convert max_matches_ into a
> constant. Peter, what do you think?

Yes.

[tfarina (gmail-do not use), 2010-05-15 23:08:49]

On 2010/05/07 14:49:38, sky wrote:
> I'm inclined to nuke set_max_matches as well and convert max_matches_ into a
> constant. Peter, what do you think?

Done. Please, take another look.

[Peter Kasting, 2010-05-16 00:33:59]

http://codereview.chromium.org/2013008/diff/11001/12002
File chrome/browser/autocomplete/autocomplete.h (right):

http://codereview.chromium.org/2013008/diff/11001/12002#newcode541
chrome/browser/autocomplete/autocomplete.h:541: static size_t max_matches() {
return kMaxMatches; }
Nit: I'd eliminate both these max_matches() functions in favor of just making
the kMaxMatches constants public.

http://codereview.chromium.org/2013008/diff/11001/12002#newcode579
chrome/browser/autocomplete/autocomplete.h:579: static const size_t kMaxMatches
= 3;
Nit: I believe you'll have difficulties on some compilers if you declare this
way?  It's always safe to just declare the name in the header, and actually
define the constant in the .cc file (as we were doing before).

[tfarina (gmail-do not use), 2010-05-17 00:18:52]

http://codereview.chromium.org/2013008/diff/11001/12002
File chrome/browser/autocomplete/autocomplete.h (right):

http://codereview.chromium.org/2013008/diff/11001/12002#newcode541
chrome/browser/autocomplete/autocomplete.h:541: static size_t max_matches() {
return kMaxMatches; }
On 2010/05/16 00:33:59, Peter Kasting wrote:
> Nit: I'd eliminate both these max_matches() functions in favor of just making
> the kMaxMatches constants public.

Done.

http://codereview.chromium.org/2013008/diff/11001/12002#newcode579
chrome/browser/autocomplete/autocomplete.h:579: static const size_t kMaxMatches
= 3;
On 2010/05/16 00:33:59, Peter Kasting wrote:
> Nit: I believe you'll have difficulties on some compilers if you declare this
> way?  It's always safe to just declare the name in the header, and actually
> define the constant in the .cc file (as we were doing before).

Done.

[Peter Kasting, 2010-05-17 17:51:50]

LGTM

http://codereview.chromium.org/2013008/diff/19001/20003
File chrome/browser/autocomplete/history_contents_provider.cc (right):

http://codereview.chromium.org/2013008/diff/19001/20003#newcode178
chrome/browser/autocomplete/history_contents_provider.cc:178: // is different
than both max_matches (the provider's maximum) and
Nit: max_matches -> kMaxMatches

http://codereview.chromium.org/2013008/diff/19001/20005
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/2013008/diff/19001/20005#newcode1
chrome/browser/autocomplete/keyword_provider.cc:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
Nit: 2010

[tfarina (gmail-do not use), 2010-05-18 01:07:32]

I'm going to commit this.

http://codereview.chromium.org/2013008/diff/19001/20003
File chrome/browser/autocomplete/history_contents_provider.cc (right):

http://codereview.chromium.org/2013008/diff/19001/20003#newcode178
chrome/browser/autocomplete/history_contents_provider.cc:178: // is different
than both max_matches (the provider's maximum) and
On 2010/05/17 17:51:50, Peter Kasting wrote:
> Nit: max_matches -> kMaxMatches

Done.

http://codereview.chromium.org/2013008/diff/19001/20005
File chrome/browser/autocomplete/keyword_provider.cc (right):

http://codereview.chromium.org/2013008/diff/19001/20005#newcode1
chrome/browser/autocomplete/keyword_provider.cc:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2010/05/17 17:51:50, Peter Kasting wrote:
> Nit: 2010

Done.