Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2012011: Add an update_url parameter to image_to_live. (Closed)

Created:
10 years, 7 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, seano, kmixter
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Add an update_url parameter to image_to_live. So it could update netbook from a dev server hosted on another server.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/scripts/image_to_live.sh View 3 chunks +11 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ericli
10 years, 7 months ago (2010-05-12 17:06:49 UTC) #1
seano
http://codereview.chromium.org/2012011/diff/1/2 File src/scripts/image_to_live.sh (right): http://codereview.chromium.org/2012011/diff/1/2#newcode96 src/scripts/image_to_live.sh:96: echo 'CHROMEOS_AUSERVER=${devserver_url}' >> \ You don't need to do ...
10 years, 7 months ago (2010-05-12 17:17:42 UTC) #2
ericli
http://codereview.chromium.org/2012011/diff/1/2 File src/scripts/image_to_live.sh (right): http://codereview.chromium.org/2012011/diff/1/2#newcode96 src/scripts/image_to_live.sh:96: echo 'CHROMEOS_AUSERVER=${devserver_url}' >> \ I guess the problem is ...
10 years, 7 months ago (2010-05-12 17:57:08 UTC) #3
seano
Understood.. LGTM
10 years, 7 months ago (2010-05-12 18:01:01 UTC) #4
kmixter
10 years, 7 months ago (2010-05-12 18:47:14 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698