Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 201128: Adds a dummy file so git users can run layout tests on Vista (Closed)

Created:
11 years, 3 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds a dummy file so git users can run layout tests on Vista Currently folks who use git to check out the chromium repo cannot run the layout tests on vista because run_webkit_tests.py checks for the existence of platform/chromium-win-vista and git, unlike SVN, will not create an empty directory if one exists upstream. This works around the issue by adding a dummy file to platform/chromium-win-vista so the directory always is there. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A webkit/data/layout_tests/platform/chromium-win-vista/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
11 years, 3 months ago (2009-09-15 23:04:35 UTC) #1
Dirk Pranke
11 years, 3 months ago (2009-09-15 23:10:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698