Chrome should shut down cleanly when quit from the Dock icon menu, during...

Chrome should shut down cleanly when quit from the Dock icon menu, during
user logout, and during system restart and shutdown.

MainMenu.xib changes (because you're not expected to parse nibs yourself):
 - The quit menu item's action is changed from the AppController object's
   -quit: method (which no longer exists) to the application object's
   -terminate: method (the Cocoa standard).
 - The application and owner object types are changed from NSApplication to
   CrApplication.
 - The application menu name is changed from Chromium to
   ^IDS_SHORT_PRODUCT_NAME.  Cocoa doesn't use this anyway, it gets replaced
   at runtime with the localized value of CFBundleName, but we shouldn't have
   branding-specific strings in our nibs.

BUG=18078
TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch.
     You should NOT see the "Google Chrome didn't shut down correctly" info bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26269

[TVL, 2009-09-15 20:07:43]

http://codereview.chromium.org/201121/diff/1/5
File chrome/app/app-Info.plist (right):

http://codereview.chromium.org/201121/diff/1/5#newcode188
Line 188: <string>MainMenu</string>
is this key worth having since we manually load the xib ourselves?

[Mark Mentovai, 2009-09-15 20:11:56]

http://codereview.chromium.org/201121/diff/1/5
File chrome/app/app-Info.plist (right):

http://codereview.chromium.org/201121/diff/1/5#newcode188
Line 188: <string>MainMenu</string>
TVL wrote:
> is this key worth having since we manually load the xib ourselves?

It doesn't hurt to include either of these, and something other than the Cocoa
init that we're not using might actually care.

[pink (ping after 24hrs), 2009-09-15 21:11:21]

LGTM

http://codereview.chromium.org/201121/diff/1/2
File chrome/browser/chrome_application_mac.mm (right):

http://codereview.chromium.org/201121/diff/1/2#newcode68
Line 68: // Using Chrome's delegate, shouldReturn should always be YES, so
exit()
if that's the case, is it worth having this here at all?

[Mark Mentovai, 2009-09-15 21:32:35]

http://codereview.chromium.org/201121/diff/1/2
File chrome/browser/chrome_application_mac.mm (right):

http://codereview.chromium.org/201121/diff/1/2#newcode68
Line 68: // Using Chrome's delegate, shouldReturn should always be YES, so
exit()
pink wrote:
> if that's the case, is it worth having this here at all?

Yeah, when I started with this I was doing things more generically and actually
had work being done in the delegate method.  Eventually I moved that into the
applicationWillTerminate: method.  Since this class is purpose-specific,
terminateShouldReturn: no longer makes sense, so I'm getting rid of it.