Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 20112: Cleanup forward declared classes that are not needed. (Closed)

Created:
11 years, 10 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Cleanup forward declared classes that are not needed in chrome/renderer, chrome/test/, and chrome/views. Also fix some lint issues while I'm at it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9289

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -56 lines) Patch
M chrome/renderer/render_process.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/automation/window_proxy.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/views/base_button.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/views/button.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M chrome/views/button_dropdown.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/views/dialog_delegate.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/views/native_button.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/views/native_control.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/views/table_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/views/view.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/views/window.h View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
11 years, 10 months ago (2009-02-05 23:36:11 UTC) #1
Evan Stade
DISALLOW_COPY_AND_ASSIGN is preferred to DISALLOW_EVIL_CONSTRUCTORS (as long as you're touching that stuff might as well ...
11 years, 10 months ago (2009-02-05 23:38:23 UTC) #2
Lei Zhang
On 2009/02/05 23:38:23, estade wrote: > DISALLOW_COPY_AND_ASSIGN is preferred to DISALLOW_EVIL_CONSTRUCTORS (as long as > ...
11 years, 10 months ago (2009-02-05 23:51:42 UTC) #3
Evan Stade
11 years, 10 months ago (2009-02-05 23:59:36 UTC) #4
I actually don't think it's a rietveld bug. Look at the last lines of the raw
patch:

 #endif  // CHROME_RENDERER_RENDER_PROCESS_H__
-

LGTM with EOF newlines fixed

Powered by Google App Engine
This is Rietveld 408576698