Issue 201114: Implemented Object.keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201114: Implemented Object.keys. (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Implemented Object.keys.

Patch Set 1 #

Patch Set 2 : moved test #

Total comments: 1

Patch Set 3 : try-again #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -36 lines)			Patch
M	LICENSE	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/handles.cc	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/messages.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	5 chunks	+21 lines, -4 lines	0 comments	Download
M	src/v8natives.js	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	test/mjsunit/testcfg.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	test/mjsunit/third_party/array-splice-webkit.js	View	2 chunks	+25 lines, -23 lines	0 comments	Download
A	test/mjsunit/third_party/object-keys.js	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A +	test/mjsunit/third_party/regexp-pcre.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 3 months ago (2009-09-15 11:49:07 UTC) #2

LGTM

http://codereview.chromium.org/201114/diff/2001/2003
File src/api.cc (right):

http://codereview.chromium.org/201114/diff/2001/2003#newcode1991
Line 1991: i::Handle<i::FixedArray> value = i::GetKeysInFixedArrayFor(
I think I would move 

"i::GetKeysInFixedArrayFor(self, i::INCLUDE_PROTOS);"

to the next line instead.

Expand Messages | Collapse Messages