Issue 201068: NNTP: Disable tabbing to hidden elements....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201068: NNTP: Disable tabbing to hidden elements.... (Closed)

Created:
11 years, 3 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NNTP: Disable tabbing to hidden elements. This is a work around since the WebKit fix is not on the M3 branch. BUG=15711 TEST=Tab around. At all times something on the page should have focus (unless the address bar got the focus).

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	chrome/browser/resources/new_new_tab.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/new_new_tab.js	View	1 2 3	8 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

Make sure that we don't have any hidden elements with a tabIndex.

11 years, 3 months ago (2009-09-09 18:55:28 UTC) #1

lgtm!

Expand Messages | Collapse Messages