Issue 201065: Http cache: Convert data writes from sysnchronous to asynchronous....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201065: Http cache: Convert data writes from sysnchronous to asynchronous.... (Closed)

Created:
11 years, 3 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http cache: Convert data writes from sysnchronous to asynchronous. BUG=21383 TEST=covered by current unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25873

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -35 lines)			Patch
M	net/http/http_cache.cc	View	1	15 chunks	+73 lines, -31 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View	1	4 chunks	+15 lines, -4 lines	0 comments	Download
M	net/http/http_transaction_unittest.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 3 months ago (2009-09-10 05:30:58 UTC) #2

LGTM!  Very nice how the IOBuffer stuff makes this fall out trivially :)

http://codereview.chromium.org/201065/diff/1/3
File net/http/http_cache.cc (right):

http://codereview.chromium.org/201065/diff/1/3#newcode1311
Line 1311: if (rv >= 0) {
nit: if (rv >= 0 && rv != data_len) {

Expand Messages | Collapse Messages