Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 201062: Add setlocal so gcl.bat doesn't repeatedly add \depot_tools to %PATH%. (Closed)

Created:
11 years, 3 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Add setlocal so {cpplin,gcl}.bat don't repeatedly add \depot_tools to %PATH%. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25751

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cpplint.bat View 2 1 chunk +1 line, -0 lines 0 comments Download
M gcl.bat View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
11 years, 3 months ago (2009-09-09 17:01:43 UTC) #1
M-A Ruel
oops. lgtm. Isn't there other batch files with this issue?
11 years, 3 months ago (2009-09-09 17:19:08 UTC) #2
sgk
11 years, 3 months ago (2009-09-09 17:25:16 UTC) #3
cpplint.bat was missing it, too; added to this CL.

hammer.bat and revert.bat don't set any variables.

Powered by Google App Engine
This is Rietveld 408576698