Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 201055: Linux: work around broken dlsym's. (Closed)

Created:
11 years, 3 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: work around broken dlsym's. It appears that Nvidia's libGL.so is overriding dlopen/dlsym with versions that don't fully function. So far, all the users reporting this have been running Gentoo, but it might just be that they have up-to-date drivers. The report[1] suggests that all drivers >= 180 have this issue. [1] http://www.nvnews.net/vbulletin/showthread.php?t=132259 BUG=16800

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M chrome/browser/zygote_main_linux.cc View 1 3 chunks +37 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
agl
11 years, 3 months ago (2009-09-08 22:22:30 UTC) #1
Evan Martin
LGTM, one comment below http://codereview.chromium.org/201055/diff/2001/2002 File chrome/browser/zygote_main_linux.cc (right): http://codereview.chromium.org/201055/diff/2001/2002#newcode284 Line 284: static void WarnOnceAboutBrokenDlsym() { ...
11 years, 3 months ago (2009-09-08 22:26:16 UTC) #2
agl
11 years, 3 months ago (2009-09-08 22:30:06 UTC) #3
http://codereview.chromium.org/201055/diff/2001/2002
File chrome/browser/zygote_main_linux.cc (right):

http://codereview.chromium.org/201055/diff/2001/2002#newcode284
Line 284: static void WarnOnceAboutBrokenDlsym() {
On 2009/09/08 22:26:16, Evan Martin wrote:
> comment above this?  based on where you put it, you'd expect the above
comments
> to describe it but they describe the localtime_r stuff that follows

Good point. I'll move the function now and comment, referencing the first
callsite.

Powered by Google App Engine
This is Rietveld 408576698