Issue 201050: Print stack trace on exception in unit tests on Windows....

Issue 201050: Print stack trace on exception in unit tests on Windows.... (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
awong, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Print stack trace on exception in unit tests on Windows. Also remove std::vector<> from StackTrace to reduce heap usage during potential unstable execution. TEST=none BUG=http://crbug.com/20996 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25685

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -43 lines)			Patch
M	base/debug_util.h	View		1 chunk	+21 lines, -5 lines	0 comments	Download
M	base/debug_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/debug_util_posix.cc	View	1 2 3 4	1 chunk	+6 lines, -18 lines	0 comments	Download
M	base/debug_util_win.cc	View	1 2 3 4	3 chunks	+40 lines, -16 lines	1 comment	Download
M	base/test_suite.h	View	1 2	2 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by. http://codereview.chromium.org/201050/diff/3002/3007 File base/test_suite.h (right): http://codereview.chromium.org/201050/diff/3002/3007#newcode173 Line 173: // Add stack dumping support on exception ...

11 years, 3 months ago (2009-09-08 18:41:21 UTC) #2

awong

http://codereview.chromium.org/201050/diff/3002/3005 File base/debug_util_posix.cc (right): http://codereview.chromium.org/201050/diff/3002/3005#newcode119 Line 119: memset(trace_, 0, sizeof(trace_)); I don't think there's a ...

11 years, 3 months ago (2009-09-08 20:17:20 UTC) #3

M-A Ruel

Removed the memset and fixed indentation. BTW, you were looking at a stale patchset.

11 years, 3 months ago (2009-09-08 20:37:01 UTC) #4

awong

11 years, 3 months ago (2009-09-08 20:44:02 UTC) #5

LGTM with one small comment.

http://codereview.chromium.org/201050/diff/5003/5005
File base/debug_util_win.cc (right):

http://codereview.chromium.org/201050/diff/5003/5005#newcode113
Line 113: for (size_t i = 0; (i < count) && os->good(); ++i) {
size_t -> int

Expand Messages | Collapse Messages