Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 201047: GTK: Don't let the page widget(s) handle key events that webkit didn't handle... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_window_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_window_gtk.cc (revision 25635)
+++ chrome/browser/gtk/browser_window_gtk.cc (working copy)
@@ -583,17 +583,13 @@
// Handles a key event in following sequence:
// 1. Our special key accelerators, such as ctrl-tab, etc.
// 2. Gtk mnemonics and accelerators.
- // 3. Gtk binding set.
// This sequence matches the default key press handler of GtkWindow.
//
- // It's not necessary to care about the keyboard layout issue, as
- // gtk_window_activate_key() and gtk_bindings_activate_event() take care of it
- // automatically.
+ // It's not necessary to care about the keyboard layout, as
+ // gtk_window_activate_key() takes care of it automatically.
if (!HandleCustomAccelerator(event->keyval, GdkModifierType(event->state),
browser_.get())) {
- if (!gtk_window_activate_key(window_, event)) {
- gtk_bindings_activate_event(GTK_OBJECT(window_), event);
- }
+ gtk_window_activate_key(window_, event);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698