src/x64/regexp-macro-assembler-x64.cc - Issue 201042: Win64 - Allow returning two values from a runtime function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/regexp-macro-assembler-x64.cc

Issue 201042: Win64 - Allow returning two values from a runtime function. (Closed)

Patch Set: Fixed typo. Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/regexp-macro-assembler-x64.cc

diff --git a/src/x64/regexp-macro-assembler-x64.cc b/src/x64/regexp-macro-assembler-x64.cc

index 963d80ebdacae8577c8395e6388b647202c64879..5d17a2d2af3ea7929f5e3ec7e1a3e2e69b80a4fe 100644

--- a/src/x64/regexp-macro-assembler-x64.cc

+++ b/src/x64/regexp-macro-assembler-x64.cc

@@ -612,7 +612,7 @@ Handle<Object> RegExpMacroAssemblerX64::GetCode(Handle<String> source) {

// MSVC passes arguments in rcx, rdx, r8, r9, with backing stack slots.

// Store register parameters in pre-allocated stack slots,

__ movq(Operand(rbp, kInputString), rcx);

- __ movzxlq(Operand(rbp, kStartIndex), rdx); // Passed as int in eax.

+ __ movq(Operand(rbp, kStartIndex), rdx); // Passed as int32 in edx.

__ movq(Operand(rbp, kInputStart), r8);

__ movq(Operand(rbp, kInputEnd), r9);

// Callee-save on Win64.