Win64 - Allow returning two values from a runtime function.

src/codegen.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 268 matching lines @@
     PrintF("CompareStub (cc %d), (strict %s)\n",
            static_cast<int>(cc_),
            strict_ ? "true" : "false");
   }
 #endif
 };
 
 
 class CEntryStub : public CodeStub {
  public:
-  CEntryStub() { }
+  explicit CEntryStub(int result_size) : result_size_(result_size) { }
 
   void Generate(MacroAssembler* masm) { GenerateBody(masm, false); }
 
  protected:
   void GenerateBody(MacroAssembler* masm, bool is_debug_break);
   void GenerateCore(MacroAssembler* masm,
                     Label* throw_normal_exception,
                     Label* throw_termination_exception,
                     Label* throw_out_of_memory_exception,
                     StackFrame::Type frame_type,
                     bool do_gc,
                     bool always_allocate_scope);
   void GenerateThrowTOS(MacroAssembler* masm);
   void GenerateThrowUncatchable(MacroAssembler* masm,
                                 UncatchableExceptionType type);
+ private:
+  // Number of pointers/values returned.
+  int result_size_;
 
- private:
   Major MajorKey() { return CEntry; }
-  int MinorKey() { return 0; }
+  // Minor key must differ if different result_size_ values means different
+  // code is generated.
+  int MinorKey();
 
   const char* GetName() { return "CEntryStub"; }
 };
 
 
 class CEntryDebugBreakStub : public CEntryStub {
  public:
-  CEntryDebugBreakStub() { }
+  explicit CEntryDebugBreakStub() : CEntryStub(1) { }

[Søren Thygesen Gjesse, 2009/09/07 12:22:33]

explicit only required when there is one argument, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Explicit_Const...

[Lasse Reichstein, 2009/09/08 11:51:35]

Good catch.
(There was an argument at a point, but it got removed without removing the
explicit).

 
   void Generate(MacroAssembler* masm) { GenerateBody(masm, true); }
 
  private:
   int MinorKey() { return 1; }
 
   const char* GetName() { return "CEntryDebugBreakStub"; }
 };
 
 
@@ skipping 55 matching lines @@
     PrintF("ArgumentsAccessStub (type %d)\n", type_);
   }
 #endif
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODEGEN_H_