Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 201026: Add appCacheManifestUrl data member to WebURLResponse, and use it to detect '... (Closed)

Created:
11 years, 3 months ago by michaeln
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, jennb
Visibility:
Public.

Description

* Add appCacheManifestUrl data member to WebURLResponse, and use it to detect 'foreign' entries. * Complete the 'contextID' to 'hostID' renaming since that terminology is now used in webcore ResourceRequest. This patch depends on a corresponding webkit change in the chromium port. https://bugs.webkit.org/show_bug.cgi?id=28960 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25646

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M webkit/api/public/WebURLRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/api/public/WebURLResponse.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/api/src/WebURLRequest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/api/src/WebURLResponse.cpp View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M webkit/appcache/web_application_cache_host_impl.cc View 1 2 3 chunks +15 lines, -8 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaeln
Eric, here's he chrome side of things your looking at in our chromium port in ...
11 years, 3 months ago (2009-09-04 19:32:26 UTC) #1
darin (slow to review)
LGTM
11 years, 3 months ago (2009-09-05 05:05:01 UTC) #2
michaeln
I've updated this CL to keep pace with pending webkit change.
11 years, 3 months ago (2009-09-06 23:30:09 UTC) #3
darin (slow to review)
11 years, 3 months ago (2009-09-07 07:29:57 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698