Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 20098: Linux: get us to the point where we crash at browser->window()->Show() (Closed)
Patch Set: Including tony's changes Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_dll_main.cc ('k') | chrome/common/pref_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index cb8cd4b42a29d1d84f45fd19a521dccdc2f27746..42cea7f3f77b891b3308c7c9dea6465795f2d129 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -315,7 +315,13 @@ void BrowserProcessImpl::CreateFileThread() {
scoped_ptr<base::Thread> thread(
new BrowserProcessSubThread(ChromeThread::FILE));
base::Thread::Options options;
+#if defined(OS_WIN)
+ // On Windows, the FILE thread needs to be have a UI message loop which pumps
+ // messages in such a way that Google Update can communicate back to us.
options.message_loop_type = MessageLoop::TYPE_UI;
+#else
+ options.message_loop_type = MessageLoop::TYPE_IO;
+#endif
if (!thread->StartWithOptions(options))
return;
file_thread_.swap(thread);
« no previous file with comments | « chrome/app/chrome_dll_main.cc ('k') | chrome/common/pref_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698