Linux: get us to the point where we crash at browser->window()->Show()

chrome/common/pref_service.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_service.h"
 
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 114 matching lines @@
   }
 
   STLDeleteContainerPointers(prefs_.begin(), prefs_.end());
   prefs_.clear();
   STLDeleteContainerPairSecondPointers(pref_observers_.begin(),
                                        pref_observers_.end());
   pref_observers_.clear();
 }
 
 bool PrefService::LoadPersistentPrefs(const std::wstring& file_path) {
+#if defined(OS_WIN)
   DCHECK(!file_path.empty());
+#else
+  // On non-Windows platforms we haven't gotten round to this yet.
+  // TODO(port): remove this exception
+  if (file_path.empty()) {
+    NOTIMPLEMENTED();
+    return false;
+  }
+#endif
   DCHECK(CalledOnValidThread());
 
   JSONFileValueSerializer serializer(file_path);
   scoped_ptr<Value> root(serializer.Deserialize(NULL));
   if (!root.get())
     return false;
 
   // Preferences should always have a dictionary root.
   if (!root->IsType(Value::TYPE_DICTIONARY))
     return false;
@@ skipping 182 matching lines @@
 
 std::wstring PrefService::GetString(const wchar_t* path) const {
   DCHECK(CalledOnValidThread());
 
   std::wstring result;
   if (transient_->GetString(path, &result))
     return result;
 
   const Preference* pref = FindPreference(path);
   if (!pref) {
+#if defined(OS_WIN)
     DCHECK(false) << "Trying to read an unregistered pref: " << path;
+#else
+    // TODO(port): remove this exception
+#endif
     return result;
   }
   bool rv = pref->GetValue()->GetAsString(&result);
   DCHECK(rv);
   return result;
 }
 
 bool PrefService::HasPrefPath(const wchar_t* path) const {
   Value* value = NULL;
   return (transient_->Get(path, &value) || persistent_->Get(path, &value));
@@ skipping 316 matching lines @@
 
   // Pref not found, just return the app default.
   return default_value_.get();
 }
 
 bool PrefService::Preference::IsDefaultValue() const {
   DCHECK(default_value_.get());
   return default_value_->Equals(GetValue());
 }