Issue 2009004: Pulling in latest gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2009004: Pulling in latest gyp. (Closed)

Created:
10 years, 7 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang (Do not use)

CC:
chromium-reviews

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Pulling in latest gyp. BUG=None TEST=None TBR=thestig Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53864

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 5 months ago (2010-07-27 23:03:18 UTC) #2

LGTM stamp

On Tue, Jul 27, 2010 at 4:02 PM,  <bradnelson@google.com> wrote:
> Reviewers: thestig,
>
> Description:
> Pulling in latest gyp.
>
> BUG=None
> TEST=None
> TBR=thestig
>
>
> Please review this at http://codereview.chromium.org/2009004/show
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 53863)
> +++ DEPS        (working copy)
> @@ -49,7 +49,7 @@
>     "http://google-cache-invalidation-api.googlecode.com/svn/trunk@34",
>
>   "src/tools/gyp":
> -    "http://gyp.googlecode.com/svn/trunk@837",
> +    "http://gyp.googlecode.com/svn/trunk@839",
>
>   "src/v8":
>     "http://v8.googlecode.com/svn/trunk@5136",
>
>
>

Expand Messages | Collapse Messages