Issue 20081: Add explicit null checks after string conversions in the shells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20081: Add explicit null checks after string conversions in the shells. (Closed)

Created:
11 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add explicit null checks after string conversions in the shells. This fixes issue 224. Committed: http://code.google.com/p/v8/source/detail?r=1233

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -18 lines)			Patch
M	include/v8.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	samples/shell.cc	View	1 2 3	5 chunks	+19 lines, -5 lines	0 comments	Download
M	src/d8.cc	View	1 2 3	5 chunks	+24 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 10 months ago (2009-02-05 12:45:02 UTC) #2

Lgtm

http://codereview.chromium.org/20081/diff/1/2
File samples/shell.cc (right):

http://codereview.chromium.org/20081/diff/1/2#newcode255
Line 255: const char* sourceline_string =
How about making this into a function?  You have 4 copies of the code.

http://codereview.chromium.org/20081/diff/1/3
File src/d8.cc (right):

http://codereview.chromium.org/20081/diff/1/3#newcode203
Line 203: const char* sourceline_string =
Ditto.

Expand Messages | Collapse Messages