Only allows mod_image_for_test for default from behavior.

Only allows mod_image_for_test for default from behavior.

BUG=1970
TEST=Running archive build with clean build and producing
a test image and normal image and zip file.  Also running
with custom from and getting an error code with test_mod=true

This change is required because mod_image_for_test requires it
to be inside chroot.  Since the buildbot is the main user
of this script, this deals with that use case.  Other users
of this script will have to run mod_image_for_test manually
outside of archive_build

[sosa, 2010-05-05 23:42:10]

Fixes image_to_usb and archive_build to run mod_image_for_test in chroot.  Also
allows image_to_usb to be run outside of chroot, umount any auto-mount points
created outside chroot, and re-enter chroot to do test mods

[sosa, 2010-05-05 23:49:23]

actually add djmm for archive_build related change

[djmm, 2010-05-06 00:26:33]

LGTM

[djmm, 2010-05-06 00:28:54]

http://codereview.chromium.org/2008001/diff/2001/3001
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2008001/diff/2001/3001#newcode59
src/scripts/archive_build.sh:59: echo "re-run archived build without test_mod"
re-run archive_build

[Chris Masone, 2010-05-06 03:20:19]

This seems really over complicated.  Is there a compelling reason that some
scripts MUST be run outside the chroot, or is it just that we have a bunch of
stuff that assumed it'd be outside the chroot, so paths are constructed wrong
when you try to do this "restart_inside_the_chroot" thing?

It seems that the whole point of the chroot is to have an environment that we
know has the right tools and right settings and stuff.  Why are the bots doing
anything outside the chroot these days?  Can we spend a little effort to clean
out all these special cases and extra flags and make thing simpler, more likely
to be correct, and easier to maintain?

On 2010/05/06 00:28:54, djmm wrote:
> http://codereview.chromium.org/2008001/diff/2001/3001
> File src/scripts/archive_build.sh (right):
> 
> http://codereview.chromium.org/2008001/diff/2001/3001#newcode59
> src/scripts/archive_build.sh:59: echo "re-run archived build without test_mod"
> re-run archive_build

[sosa, 2010-05-06 18:29:58]

I agree, it is complicated.

The real issue with image_to_usb is the problem that there is some
code in there that actually has to be run outside of the chroot
(basically if the stick is automounted in anyway).  Nsanders is
working on a CL to strip the factory install items out of image_to_usb
altogether but I'm not sure what the timeline is on it.

Until that time, this seems like a good intermediate fix so that
image_to_usb runs in/outside of chroot with all functionality.  I
don't want to break anyone's workflow and at the same time I want you
to have what you want i.e. I don't want to tell people ... hey, yeah
use image_to_usb, but oh, if you get errors, umount /media/blah first
outside chroot then run it ... or make sure to disable automounts, etc
etc etc.

On Wed, May 5, 2010 at 8:20 PM,  <cmasone@chromium.org> wrote:
> This seems really over complicated.  Is there a compelling reason that some
> scripts MUST be run outside the chroot, or is it just that we have a bunch
> of
> stuff that assumed it'd be outside the chroot, so paths are constructed
> wrong
> when you try to do this "restart_inside_the_chroot" thing?
>
> It seems that the whole point of the chroot is to have an environment that
> we
> know has the right tools and right settings and stuff.  Why are the bots
> doing
> anything outside the chroot these days?  Can we spend a little effort to
> clean
> out all these special cases and extra flags and make thing simpler, more
> likely
> to be correct, and easier to maintain?
>
> On 2010/05/06 00:28:54, djmm wrote:
>>
>> http://codereview.chromium.org/2008001/diff/2001/3001
>> File src/scripts/archive_build.sh (right):
>
>> http://codereview.chromium.org/2008001/diff/2001/3001#newcode59
>> src/scripts/archive_build.sh:59: echo "re-run archived build without
>> test_mod"
>> re-run archive_build
>
>
>
> http://codereview.chromium.org/2008001/show
>

[sosa, 2010-05-07 00:49:48]

Have removed contentious image_to_usb changes.  Pushing archive_build component.

http://codereview.chromium.org/2008001/diff/2001/3001
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2008001/diff/2001/3001#newcode59
src/scripts/archive_build.sh:59: echo "re-run archived build without test_mod"
On 2010/05/06 00:28:55, djmm wrote:
> re-run archive_build

Done.