Finish taking out render_messages.h include from other headers.

Finish taking out render_messages.h includes from headers.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9209

[scherkus (not reviewing), 2009-02-05 03:22:15]

LGTM -- just a nit about indentation and path separators.

Style checks out.  I double checked that render_messages.h were only being
included in .cc files, which they are.  I was also able to follow where you
moved code around.

http://codereview.chromium.org/20072/diff/1/56
File chrome/common/common.scons (right):

http://codereview.chromium.org/20072/diff/1/56#newcode102
Line 102: 'accessibility.h',
Is it possible to add this for the xcodeproj as well?  I saw you deleted the old
entry, but maybe you can just rename the file it points to.

In any case, it might be easier to let the mac folks patch it in via xcode.

http://codereview.chromium.org/20072/diff/1/54
File chrome/common/common.vcproj (right):

http://codereview.chromium.org/20072/diff/1/54#newcode316
Line 316: <File
This is indented too much.  Possibly a tab vs. spaces thing.

http://codereview.chromium.org/20072/diff/1/6
File webkit/glue/context_menu.h (right):

http://codereview.chromium.org/20072/diff/1/6#newcode9
Line 9: #include "googleurl\src\gurl.h"
Should these be forward slashes?

[jam, 2009-02-05 03:25:54]

http://codereview.chromium.org/20072/diff/1/56
File chrome/common/common.scons (right):

http://codereview.chromium.org/20072/diff/1/56#newcode102
Line 102: 'accessibility.h',
On 2009/02/05 03:22:16, scherkus wrote:
> Is it possible to add this for the xcodeproj as well?  I saw you deleted the
old
> entry, but maybe you can just rename the file it points to.
> 
> In any case, it might be easier to let the mac folks patch it in via xcode.

I wasn't sure if I can just rename it, and I don't think it needs to be added
(my guess is just like VS, adding a header is done just so you can navigate to
it in the source browser).  I'll ping someone on the mac team to add it via
xcode.

http://codereview.chromium.org/20072/diff/1/54
File chrome/common/common.vcproj (right):

http://codereview.chromium.org/20072/diff/1/54#newcode316
Line 316: <File
On 2009/02/05 03:22:16, scherkus wrote:
> This is indented too much.  Possibly a tab vs. spaces thing.

Done.

http://codereview.chromium.org/20072/diff/1/6
File webkit/glue/context_menu.h (right):

http://codereview.chromium.org/20072/diff/1/6#newcode9
Line 9: #include "googleurl\src\gurl.h"
On 2009/02/05 03:22:16, scherkus wrote:
> Should these be forward slashes?

Done.

[scherkus (not reviewing), 2009-02-05 03:26:58]

cool -- don't forget the friendly clobber reminder :)